fix: filter out router so all-linear can be tuned for LoRA target modules
#142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
2 tasks
anhuong
approved these changes
Apr 30, 2025
| [testenv] | ||
| deps = | ||
| pytest>=7 | ||
| importlib-metadata |
Collaborator
There was a problem hiding this comment.
Noting this change: Error coming from linting failing to import from torch
.tox/py/lib/python3.9/site-packages/torch/distributed/elastic/rendezvous/__init__.py:142: in <module>
from .registry import _register_default_handlers, _register_out_of_tree_handlers
.tox/py/lib/python3.9/site-packages/torch/distributed/elastic/rendezvous/registry.py:19: in <module>
from importlib_metadata import entry_points
E ModuleNotFoundError: No module named 'importlib_metadata'
Which looks like something that was added 7 months ago - https://github.com/pytorch/pytorch/blame/main/torch/distributed/elastic/rendezvous/registry.py#L18
So not sure why this is coming up as a new error when it didn't fail previously. But this should not affect the image build since we run on python 3.12 and this import only happens on python < 3.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with #545 to allow all-linear for ScatterMoE. This PRs always filters out the
routerin the LoRA state dict, which should be reversed when expert tuning support for LoRA layers is added in, and has been noted as such. This will allow users to passall-linearas target modules when using ScatterMoE